Soft delete functionality #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds deleted record methods to the StorageService interface. Implemented methods in RecordService interface. Added support for permanent delete option in webservice delete API endpoint Fixed delete call in RecordController to match new method signature
…gh the storage service tier. Added audit event action string to log the type of action the user performed on the record. Added audit events for delete actions
Changed permanently deleted record action type to destroyed for better consistency
Installed core types 1.4.3 to redbox-portal Refactoed RecordsService to use destroyed RecordAuditActionType
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1891 +/- ##
========================================
Coverage 70.06% 70.06%
========================================
Files 112 112
Lines 1871 1871
Branches 218 218
========================================
Hits 1311 1311
Misses 560 560
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the new storage driver functions released in sails-hook-redbox-storage-mongo and adds webservice endpoints to support:
Also incorporates the new redbox-core-types version v1.4.3 which adds support for including the type of action occurred on the record (i.e. created, updated, deleted, recovered or destroyed).