-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test to get datarecord attachment #2105
add test to get datarecord attachment #2105
Conversation
config/routes.js
Outdated
controller: 'webservice/RecordController', | ||
action: 'listDatastreams', | ||
csrf: false | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewbrazzatti Did you intend to add another route for listDatastreams
, or change the existing route from put
to get
?
Also, doesn't the route for getDataStream
above need the datastreamId
?
'get /:branding/:portal/api/records/datastreams/:oid/:datastreamId': {
controller: 'webservice/RecordController',
action: 'getDataStream',
csrf: false
},
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2105 +/- ##
===========================================
+ Coverage 51.84% 52.11% +0.26%
===========================================
Files 163 163
Lines 8010 8007 -3
Branches 1147 1147
===========================================
+ Hits 4153 4173 +20
+ Misses 3432 3403 -29
- Partials 425 431 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Update list and get datastream tests.
This is needed to avoid conflict with the listDatastreams endpoint.
…edbox-mint/redbox-portal into feature/test-get-datarecord-attachment
… other datastream api functions
No description provided.