Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to get datarecord attachment #2105

Merged
merged 11 commits into from
May 15, 2024

Conversation

cofiem
Copy link
Contributor

@cofiem cofiem commented Apr 19, 2024

No description provided.

@cofiem cofiem requested a review from andrewbrazzatti April 19, 2024 06:09
@cofiem cofiem self-assigned this Apr 19, 2024
config/routes.js Outdated
controller: 'webservice/RecordController',
action: 'listDatastreams',
csrf: false
},
Copy link
Contributor Author

@cofiem cofiem Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewbrazzatti Did you intend to add another route for listDatastreams, or change the existing route from put to get?

Also, doesn't the route for getDataStream above need the datastreamId?

'get /:branding/:portal/api/records/datastreams/:oid/:datastreamId': {
    controller: 'webservice/RecordController',
    action: 'getDataStream',
    csrf: false
  },

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 52.11%. Comparing base (d14e8a3) to head (aa591a3).

Files Patch % Lines
...ipt/api/controllers/webservice/RecordController.ts 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2105      +/-   ##
===========================================
+ Coverage    51.84%   52.11%   +0.26%     
===========================================
  Files          163      163              
  Lines         8010     8007       -3     
  Branches      1147     1147              
===========================================
+ Hits          4153     4173      +20     
+ Misses        3432     3403      -29     
- Partials       425      431       +6     
Flag Coverage Δ
backend-mocha 48.23% <66.66%> (+0.32%) ⬆️
backend-newman 44.31% <66.66%> (+0.31%) ⬆️
frontend-core-lib 52.41% <ø> (ø)
frontend-dashboard 88.07% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewbrazzatti andrewbrazzatti merged commit 8dfd5ac into develop May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants