Hotfix: Publish event emitters keep a reference to the previous subscribers when cloned in a repeatable container #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lone as the existing subscribers are not cleared by the clone.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2300 +/- ##
=======================================
Coverage 70.09% 70.09%
=======================================
Files 112 112
Lines 1876 1876
Branches 218 218
=======================================
Hits 1315 1315
Misses 561 561
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewbrazzatti
added a commit
that referenced
this pull request
Aug 1, 2024
…lone as the existing subscribers are not cleared by the clone. (#2300)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add a new element, repeatable containers clone the first element to add a new one. The publish event emitters after cloning still hold their previous subscribers which means the sub-elements in the first elements subscribing react to changes in the new element. This fix creates new event emitter objects for each publish event so that it no longer occurs.