-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dashboard issues #2433
Merged
Merged
Fix dashboard issues #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r testing spec component
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2433 +/- ##
===========================================
+ Coverage 53.61% 56.98% +3.36%
===========================================
Files 176 176
Lines 8865 8957 +92
Branches 1260 1292 +32
===========================================
+ Hits 4753 5104 +351
+ Misses 3897 3844 -53
+ Partials 215 9 -206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is fixing a couple of issues found in the dashboard angular app. These issues are mostly edge case problems that can happen when the dashboard is used to list larger than the usual amount of records (In example around 50K+) and also because the larger list records are usually created/updated during a bulk update process (In example harvesting of lookup records). The issues fixed are listed below:
1- Pagination endless loop and/or slow performance when navigating through different pagination sets
2- Initial default column sort is not deterministic and can lead to overlapping of records in paginated sets