Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard issues #2433

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Fix dashboard issues #2433

merged 12 commits into from
Sep 24, 2024

Conversation

alejandro-bulgaris-qcif
Copy link
Contributor

This change is fixing a couple of issues found in the dashboard angular app. These issues are mostly edge case problems that can happen when the dashboard is used to list larger than the usual amount of records (In example around 50K+) and also because the larger list records are usually created/updated during a bulk update process (In example harvesting of lookup records). The issues fixed are listed below:
1- Pagination endless loop and/or slow performance when navigating through different pagination sets
2- Initial default column sort is not deterministic and can lead to overlapping of records in paginated sets

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (64cd322) to head (aa0420b).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
typescript/api/controllers/RecordController.ts 66.66% 1 Missing and 1 partial ⚠️
typescript/api/services/RecordsService.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2433      +/-   ##
===========================================
+ Coverage    53.61%   56.98%   +3.36%     
===========================================
  Files          176      176              
  Lines         8865     8957      +92     
  Branches      1260     1292      +32     
===========================================
+ Hits          4753     5104     +351     
+ Misses        3897     3844      -53     
+ Partials       215        9     -206     
Flag Coverage Δ
backend-bruno 49.59% <62.50%> (+4.23%) ⬆️
backend-mocha 54.79% <62.50%> (+4.49%) ⬆️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 52.41% <ø> (ø)
frontend-dashboard 70.18% <ø> (-9.13%) ⬇️
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alejandro-bulgaris-qcif alejandro-bulgaris-qcif merged commit e6f949f into develop Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant