Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed slowness in query response when user quickly provides a series of inputs. #2529

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

shilob
Copy link
Member

@shilob shilob commented Oct 17, 2024

The slowdown is apparent when the user enters a name in the RB query backed autocomplete widget. The fix is to wait for the user to stop providing input after a period of time, before performing a request to the server.

@shilob shilob added the bug label Oct 17, 2024
Fixed issue when creating a new row in a repeatable contributor the lookup wasn't populating the suggestion list.
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (6d2a23d) to head (e17694d).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2529      +/-   ##
===========================================
- Coverage    52.53%   52.51%   -0.03%     
===========================================
  Files          179      179              
  Lines         9374     9374              
  Branches      1354     1354              
===========================================
- Hits          4925     4923       -2     
- Misses        4229     4231       +2     
  Partials       220      220              
Flag Coverage Δ
backend-bruno 43.93% <ø> (-0.03%) ⬇️
backend-mocha 48.67% <ø> (-0.03%) ⬇️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 53.78% <ø> (ø)
frontend-dashboard 74.53% <ø> (ø)
frontend-deleted-records 86.59% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewbrazzatti andrewbrazzatti merged commit 4b6a0aa into develop Oct 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants