Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Set a default logout redirect url #2538

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

andrewbrazzatti
Copy link
Contributor

Previously with OIDC authentication, there are scenarios where the post redirect url is not available on the session which means the user is redirected to a error page. With this fix, in those scenarios the user will redirect to the default configure logout page (or the home page if this isn't set)

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (b1a9154) to head (511223a).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
typescript/api/controllers/UserController.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2538      +/-   ##
===========================================
+ Coverage    52.51%   52.52%   +0.01%     
===========================================
  Files          179      179              
  Lines         9374     9376       +2     
  Branches      1354     1356       +2     
===========================================
+ Hits          4923     4925       +2     
  Misses        4231     4231              
  Partials       220      220              
Flag Coverage Δ
backend-bruno 43.95% <0.00%> (+0.01%) ⬆️
backend-mocha 48.68% <0.00%> (+0.01%) ⬆️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 53.78% <ø> (ø)
frontend-dashboard 74.53% <ø> (ø)
frontend-deleted-records 86.59% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewbrazzatti andrewbrazzatti merged commit f8ec55e into develop Oct 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant