Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve email service #2566

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Improve email service #2566

merged 7 commits into from
Oct 31, 2024

Conversation

cofiem
Copy link
Contributor

@cofiem cofiem commented Oct 28, 2024

  • Combine common operations into EmailService, including checking defaults.
  • Allow additional email options to be templates.

@cofiem cofiem self-assigned this Oct 28, 2024
@cofiem cofiem marked this pull request as ready for review October 29, 2024 01:05
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 83.95062% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.60%. Comparing base (bb0787a) to head (edad820).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
typescript/api/services/EmailService.ts 80.00% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2566      +/-   ##
===========================================
+ Coverage    52.52%   52.60%   +0.07%     
===========================================
  Files          179      167      -12     
  Lines         9376     8841     -535     
  Branches      1356     1280      -76     
===========================================
- Hits          4925     4651     -274     
+ Misses        4231     3968     -263     
- Partials       220      222       +2     
Flag Coverage Δ
backend-bruno 44.53% <79.01%> (+0.58%) ⬆️
backend-mocha 49.30% <83.95%> (+0.61%) ⬆️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib ?
frontend-dashboard 74.53% <ø> (ø)
frontend-deleted-records ?
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewbrazzatti andrewbrazzatti merged commit 5f912f8 into develop Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants