Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing additional options when sending email #2614

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

cofiem
Copy link
Contributor

@cofiem cofiem commented Nov 19, 2024

No description provided.

@cofiem cofiem self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.38%. Comparing base (b762cd9) to head (c24dde6).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
typescript/api/services/EmailService.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2614      +/-   ##
===========================================
+ Coverage    53.32%   53.38%   +0.06%     
===========================================
  Files          179      179              
  Lines         9456     9458       +2     
  Branches      1364     1366       +2     
===========================================
+ Hits          5042     5049       +7     
+ Misses        4193     4190       -3     
+ Partials       221      219       -2     
Flag Coverage Δ
backend-bruno 44.90% <60.00%> (-0.03%) ⬇️
backend-mocha 49.76% <60.00%> (+0.07%) ⬆️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 53.78% <ø> (ø)
frontend-dashboard 74.53% <ø> (ø)
frontend-deleted-records 86.59% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cofiem cofiem marked this pull request as ready for review November 27, 2024 01:24
@andrewbrazzatti andrewbrazzatti merged commit 4a1ddbe into develop Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants