Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move healthchecks to it's own package #1011

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Move healthchecks to it's own package #1011

merged 1 commit into from
Oct 31, 2024

Conversation

trevorriles
Copy link
Contributor

This avoids initializing the server packages when only sending a healthcheck.

Move healthchecks to it's own package
9fa45da 
This avoids initializing the server packages when only sending a
healthcheck.
@trevorriles trevorriles requested a review from a team as a code owner October 31, 2024 21:06
chriskuehl
chriskuehl approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@chriskuehl chriskuehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the performance improvement from cutting out all the unnecessary imports is significant (~1100ms => ~590ms from within the exact same pod talking to the same server). Seems clearly worth it.

@chriskuehl chriskuehl merged commit bb9d417 into develop Oct 31, 2024
4 checks passed
@chriskuehl chriskuehl deleted the push-quxltqkzwwyx branch October 31, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskuehl chriskuehl chriskuehl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevorriles @chriskuehl