Patch gevent to work with tracing #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 27, 2024 13:10
This resolves an issue where some logs are missing the tracing info when running on different greenlets, this is also already used in graphql.py to ensure client requests have the correct context when running on different greenlets.
We initate the patch when baseplate-serve is called. I've add a very simple test that shows that the parent relationship is correct when patched but incorrect when unpatched.
chriskuehl
approved these changes
Dec 2, 2024
chriskuehl
reviewed
Dec 3, 2024
chriskuehl
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrument gevent so that it passes opentelemetry context to greenlets. We already have a similar implementation deployed to reddit's internal graphql service. After receiving a bug report from other services missing trace context propagation the fix is being move into baseplate.py.
I've verified that this fix resolves an issue where log lines inside of a greenlet were missing the tracing info.