Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot #850

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Update dependabot #850

merged 1 commit into from
Apr 11, 2024

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Apr 10, 2024

💸 TL;DR

  • Increase python open PRs from default 5 to 20.
  • Add dependabot updates for github actions.
  • Update actions and pin versions to hash for supply chain security safety.
  • Add a runtime.txt file to trick dependabot into thinking this is the
    required version for updates.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@SuperQ SuperQ requested a review from a team as a code owner April 10, 2024 22:04
@SuperQ SuperQ requested a review from chriskuehl April 10, 2024 22:04
* Increase python open PRs from default 5 to 20.
* Add dependabot updates for github actions.
* Update actions and pin versions to hash for supply chain security safety.
* Add a `runtime.txt` file to trick dependabot into thinking this is the
  required version for updates.

Signed-off-by: SuperQ <superq@gmail.com>
Comment on lines +1 to +2
python-3.8
# Specifies the python version that dependabot should use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, I'm planning to try out migrating this repo to Poetry sometime soon, which should obviate the need for this (since Poetry solves for all Python versions and can deal with different constraints for each). OK to merge this now but might become unnecessary later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I was just looking to get in workarounds to avoid dependabot trying to update things that would fail CI.

@bjk-reddit bjk-reddit merged commit 6c2b340 into reddit:develop Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants