Use Self type in _BaseKafkaQueueConsumerFactory.new()

[salomon-smekecohen]

Closes #797

💸 TL;DR

Correct a typing annotation

🧪 Testing Steps / Validation

Lint pass in ci

✅ Checks

• CI tests (if present) are passing
• Adheres to code style for repo
• Contributor License Agreement (CLA) completed if not a Reddit employee

Before:

After:

[salomon-smekecohen]

This is already a dependency, just an indirect one. Moved to direct since I import from it.

[chriskuehl]

Do you think it's worth doing

try:
    from typing import Self  # Python >= 3.11
except ImportError:
    from typing_extensions import Self

and then doing this in pyproject.toml:

typing-extensions = {version = "^4.11.0", python = "<3.11"}

?

[salomon-smekecohen]

I thought about that. I wound up here given the dependency still exists in 3.12, and that mypy deprecates typing_extensions when appropriate. I think theyre both fine, this looked nicer to me. Easier to clean up.

…

On Mon, Apr 29, 2024 at 16:04 Chris Kuehl ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In baseplate/frameworks/queue_consumer/kafka.py <https://protect.checkpoint.com/v2/___https://github.com/reddit/baseplate.py/pull/894%23discussion_r1583768044___.YzJ1OnJlZGRpdDpjOmc6OTBlNTViOWI1MmZlN2E3NDA0NWNiOTE0NDE1NDY0MDM6NjpmNWYzOjIzM2ZmNTAyYmZjNzBlZGZhM2U3M2IxZDM2NjcwZGQxMDc5OTczZDgzZjVkNTFlYThiNzg0MWIxNTIyNjJkYjI6aDpU> : > @@ -19,6 +19,7 @@ from prometheus_client import Counter from prometheus_client import Gauge from prometheus_client import Histogram +from typing_extensions import Self Do you think it's worth doing try: from typing import Self # Python >= 3.11except ImportError: from typing_extensions import Self and then doing this in pyproject.toml: typing-extensions = {version = "^4.11.0", python = "<3.11"} ? — Reply to this email directly, view it on GitHub <https://protect.checkpoint.com/v2/___https://github.com/reddit/baseplate.py/pull/894%23pullrequestreview-2029637551___.YzJ1OnJlZGRpdDpjOmc6OTBlNTViOWI1MmZlN2E3NDA0NWNiOTE0NDE1NDY0MDM6NjphODZmOjU5N2M4ODI3YmM0NjE2YWZjOTJjZDlmMjYwMWFmNmMwZDczNDRiNzJkY2QyZjU1MmNlMTE1NGU3OTlkNzU4Y2M6aDpU>, or unsubscribe <https://protect.checkpoint.com/v2/___https://github.com/notifications/unsubscribe-auth/BAA37MISXR4OGOUDANLVGNDY72YWZAVCNFSM6AAAAABG63ZYCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRZGYZTONJVGE___.YzJ1OnJlZGRpdDpjOmc6OTBlNTViOWI1MmZlN2E3NDA0NWNiOTE0NDE1NDY0MDM6Njo5OTVhOjBhZTRkZjRhYzk1MTVlN2E2ZmNjODk1YWY0OGZhODc2ZWFkZGRhYWJiMmQ3N2IyOWY1ZTE0ZDllNzViYTQzYzE6aDpU> . You are receiving this because you authored the thread.Message ID: ***@***.***>