Patch using opentelemetry-instrumentation-threading #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help track context across threads in baseplate services
|
Will fix up these errors after lunch. It seems like the exceptions are now stored with the full classpath. |
redloaf
approved these changes
Aug 5, 2024
chriskuehl
approved these changes
Aug 8, 2024
trevorriles
pushed a commit
that referenced
this pull request
Aug 20, 2024
This reverts commit 6c5d467.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves some context passing issues when crossing thread boundaries. It also upgrades opentelemetry libs to 1.25.0, which is the release that includes official python 3.12 support.
We apply the instrumentation in this case as a side-effect, similar to how we do the gevent monkey patching.