[BUG] openshift-tools-installer fails to find chart-verifier releases

[komish]

Version

All versions

Describe the bug

openshift-tools-installer fails to find chart-verifier 1.13.6 release binary tarballs in the list of release assets.

Steps to reproduce, workflow links, screenshots

• No steps to reproduce because we've worked around this issue for the Chart Verifier 1.13.6 release to unblock users.

• See Installing chart-verifier from openshift-tools-installer fails due to release asset being malformed redhat-certification/chart-verifier#463 for a detailed synopsis of what was going wrong.

Context

I maintain https://github.com/redhat-certification/chart-verifier.

The problem here is the filtering that's applied within openshift-tools-installer. Chart Verifier undergoes the default release asset filtering (filterByOs, filterByArch, filterByZipped).

In the past, we only had a single release asset that was published. When openshift-tools-installer encounters only a single release asset, it skips remaining filtering (i.e. all filters). Now that we have 2 assets, the first filter (filterByOs) is filtering out everything, and returning 0 assets.

Chart Verifier either needs to rename their release asset, or needs custom filters here. I'm leaning the filtering route for now because there may be other locations that use our release asset names as they exist.

I've got some filters that work. I'll submit them as a PR here shortly.

[komish]

cc @jessesimpson36 - thanks for reporting this