Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply custom filters to chart-verifier install requests #109

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

komish
Copy link
Contributor

@komish komish commented Aug 7, 2024

Description

Applies custom filters to the chart-verifier (via github) installation.

Related Issue(s)

fixes #108

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

  • Set custom file-finding filters for chart-verifier installs to fix a bug in detecting the release asset when multiple assets are present.

@komish komish force-pushed the fix-chart-verifier-filters branch 3 times, most recently from fc9d496 to 8e75adf Compare August 7, 2024 16:14
@komish
Copy link
Contributor Author

komish commented Aug 7, 2024

PTAL @divyansh42

@divyansh42
Copy link
Member

@komish Thanks for the PR
CI tests were disabled due to no activity. I have enabled them again.
Could you please do a force push (or empty push) to trigger the tests again.

@komish
Copy link
Contributor Author

komish commented Aug 9, 2024

@divyansh42 sure thing, coming momentarily

Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
@komish komish force-pushed the fix-chart-verifier-filters branch from 8e75adf to c8d64d7 Compare August 9, 2024 12:48
@divyansh42 divyansh42 merged commit 865b356 into redhat-actions:main Aug 9, 2024
25 of 27 checks passed
@divyansh42
Copy link
Member

Changes should reflect in v1. v1.13 and v1.13.1 tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] openshift-tools-installer fails to find chart-verifier releases
2 participants