-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVKP-5832: maintain pinning of watcher image to mem leak version #4071
SRVKP-5832: maintain pinning of watcher image to mem leak version #4071
Conversation
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -1774,7 +1774,7 @@ spec: | |||
)" \ | |||
--dry-run=client \ | |||
-o yaml | kubectl apply -f - | |||
image: quay.io/konflux-ci/appstudio-utils:ab6b0b8e40e440158e7288c73aff1cf83a2cc8a9@sha256:24179f0efd06c65d16868c2d7eb82573cce8e43533de6cea14fec3b7446e0b14 | |||
image: quay.io/redhat-appstudio/appstudio-utils:dbbdd82734232e6289e8fbae5b4c858481a7c057 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line has to be reverted manually until we switch that line https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/production/base/kustomization.yaml#L11 to match the one in staging which points to a pipeline-service SHA including the fix.
The same goes for all production deploy.yaml files.
c41c3b4
to
7e49b4d
Compare
@enarha PR rebased now that July 16 prod bump has gone through - PTAL / thanks |
That is not enough because the prod update did not include the newest SHA from the pipeline-service repo, but took only 2 commits including the OSP bump. You need to update https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/production/base/kustomization.yaml#L11 to da64420f8df634736b1aff727155e626ec832dd1 if you want to include the fixes. |
rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
7e49b4d
to
d3a2a3e
Compare
thanks updated @enarha |
/lgtm |
d0850ac
into
redhat-appstudio:main
Until @khrm can either productize his third party tool integration for results log storage, or unless the backup option of accessing S3 from the watcher is done at a tactical solution, the current mem leak version of the watcher still provides slightly better success / performance than the versions that fix the mem leak / cancelled context issues but are more negatively impacted by grpc/http2 scaling issues.
I did run
generate-deploy-config.sh
@enarha in both the staging and production folders.rh-pre-commit.version: 2.3.0
rh-pre-commit.check-secrets: ENABLED