Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tempo operator to enable viewing traces in development environment #4075

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add Tempo operator to enable viewing traces in development environment #4075

merged 2 commits into from
Jul 18, 2024

Conversation

raks-tt
Copy link
Contributor

@raks-tt raks-tt commented Jul 16, 2024 •
edited

The Tempo operator exposes the Jaeger UI, enabling the viewing of traces exclusively in the development environment.

Tested the traces:
image

@openshift-ci openshift-ci bot requested review from mftb and ralphbean July 16, 2024 00:09
@raks-tt raks-tt changed the title Add Tempo operator to enable viewing traces in development environment Draft: Add Tempo operator to enable viewing traces in development environment Jul 16, 2024
@raks-tt raks-tt force-pushed the grafana-tempo-operator branch 4 times, most recently from bb5d7af to 237adbb Compare July 16, 2024 05:37
@raks-tt
Copy link
Contributor Author

raks-tt commented Jul 16, 2024

/retest

@raks-tt raks-tt force-pushed the grafana-tempo-operator branch 3 times, most recently from b84264f to b7f234b Compare July 16, 2024 13:43
@mftb
Copy link
Contributor

mftb commented Jul 16, 2024

/retest

@raks-tt raks-tt force-pushed the grafana-tempo-operator branch 3 times, most recently from 281a13d to a9fc043 Compare July 17, 2024 13:17
@raks-tt raks-tt changed the title Draft: Add Tempo operator to enable viewing traces in development environment Add Tempo operator to enable viewing traces in development environment Jul 17, 2024
@raks-tt raks-tt force-pushed the grafana-tempo-operator branch 2 times, most recently from fed8deb to 94e2235 Compare July 17, 2024 14:49
rrajashe added 2 commits July 17, 2024 13:04
Add tempo operator
0552881 
The Tempo operator exposes the Jaeger UI,
enabling the viewing of traces exclusively in the dev environment.
Update Jaegar endpoint in Otel configuration
83c0221
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 17, 2024

@raks-tt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 83c0221 link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mftb
mftb approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@mftb mftb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2024
@raks-tt
Copy link
Contributor Author

raks-tt commented Jul 18, 2024

/assign @arewm

@arewm
Copy link
Contributor

arewm commented Jul 18, 2024

I am not sure that I am the best person to review this PR. @gbenhaim or @hugares, do you know who might be better to review it?

@arewm arewm removed their assignment Jul 18, 2024
@hugares
Copy link
Contributor

hugares commented Jul 18, 2024

I am not sure that I am the best person to review this PR. @gbenhaim or @hugares, do you know who might be better to review it?

Either one of us :) Let me have a look

hugares
hugares approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, mftb, pavolloffay, raks-tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1e77a84 into redhat-appstudio:main Jul 18, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mftb mftb mftb approved these changes

@hugares hugares hugares approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

@ralphbean ralphbean Awaiting requested review from ralphbean

Assignees

@mftb mftb

@hugares hugares

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
5 participants
@raks-tt @mftb @arewm @hugares @pavolloffay