Improve nginx deployment #4085
Improve nginx deployment #4085
Conversation
1. For 60 seconds, check if no containers in the pod crash loop and only then declare that the pod ready. 2. Add readiness probe. Traffic will be forwarded only to pods that pass the readiness check. 3. Adjust probes to start only after 60 seconds to match the change mention in 1. 4. During upgrade, allow an additional pod to be scheduled for the new replicaset. 5. Don't allow the deployment to have less that 3 pod ready, even during upgrade. Signed-off-by: gbenhaim <gbenhaim@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit, filariow, gbenhaim, hugares, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test appstudio-e2e-tests |
|
/retest |
|
@gbenhaim: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit b4c0e64
into
redhat-appstudio:main
For 60 seconds, check if no containers in the pod crash loop and only then declare that the pod ready.
Add readiness probe. Traffic will be forwarded only to pods that pass the readiness check.
Adjust probes to start only after 60 seconds to match the change mention in 1.
During upgrade, allow an additional pod to be scheduled for the new replicaset.
Don't allow the deployment to have less that 3 pod ready, even during upgrade.