Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspaces: add production configuration #4225

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

sadlerap
Copy link
Contributor

No description provided.

@sadlerap
Copy link
Contributor Author

/hold

We may want to merge konflux-workspaces/workspaces#254 and roll its subsequent release out to staging before merging this.

@sadlerap
Copy link
Contributor Author

/unhold

This should be good to review.

@sadlerap
Copy link
Contributor Author

Tests are failing due to an issue with toolchain-e2e, see #4324 for context.

@sadlerap
Copy link
Contributor Author

/retest

1 similar comment
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap
Copy link
Contributor Author

/hold

Wait for #4224 to merge, since it might delete/recreate all resources.

@sadlerap
Copy link
Contributor Author

/retest

2 similar comments
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap
Copy link
Contributor Author

/retest

@sadlerap
Copy link
Contributor Author

/unhold

#4224 has merged without any issue.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
We need to do a bit of request rewriting, since konflux workspaces
doesn't expect /api/k8s/ in its path matching rules, but we should have
workspaces act like a part of the k8s api exposed to everyone else.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap
Copy link
Contributor Author

/retest

3 similar comments
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap
Copy link
Contributor Author

/retest

@sadlerap
Copy link
Contributor Author

/retest

sadlerap added a commit to sadlerap/konflux-workspaces that referenced this pull request Aug 21, 2024
To run these tests, you'll need to obtain a token corresponding to the
environment you're wanting to test.  Tokens are not portable, i.e. a
token from staging-external won't work for production-external.

Internal environments are not yet supported, since the PR for enabling
them has not yet landed.  See [#4225] for details.

[#4225]: redhat-appstudio/infra-deployments#4225

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@filariow
Copy link
Member

/retest
/lgtm

Copy link

openshift-ci bot commented Aug 22, 2024

@sadlerap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 871db7b link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sadlerap added a commit to sadlerap/konflux-workspaces that referenced this pull request Aug 22, 2024
To run these tests, you'll need to obtain a token corresponding to the
environment you're wanting to test.  Tokens are not portable, i.e. a
token from staging-external won't work for production-external.

Internal environments are not yet supported, since the PR for enabling
them has not yet landed.  See [#4225] for details.

[#4225]: redhat-appstudio/infra-deployments#4225

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap
Copy link
Contributor Author

/hold
Merge this on Monday; let's not break production before a weekend.

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadlerap
Copy link
Contributor Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 805ff13 into redhat-appstudio:main Aug 26, 2024
6 of 7 checks passed
@sadlerap sadlerap deleted the workspaces-prod branch August 26, 2024 14:34
sadlerap added a commit that referenced this pull request Aug 26, 2024
hugares pushed a commit that referenced this pull request Aug 26, 2024
sadlerap added a commit to sadlerap/konflux-workspaces that referenced this pull request Aug 27, 2024
To run these tests, you'll need to obtain a token corresponding to the
environment you're wanting to test.  Tokens are not portable, i.e. a
token from staging-external won't work for production-external.

Internal environments are not yet supported, since the PR for enabling
them has not yet landed.  See [#4225] for details.

[#4225]: redhat-appstudio/infra-deployments#4225

Signed-off-by: Andy Sadler <ansadler@redhat.com>
openshift-merge-bot bot pushed a commit to konflux-workspaces/workspaces that referenced this pull request Aug 27, 2024
To run these tests, you'll need to obtain a token corresponding to the
environment you're wanting to test.  Tokens are not portable, i.e. a
token from staging-external won't work for production-external.

Internal environments are not yet supported, since the PR for enabling
them has not yet landed.  See [#4225] for details.

[#4225]: redhat-appstudio/infra-deployments#4225

Signed-off-by: Andy Sadler <ansadler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants