-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspaces: add production configuration #4225
workspaces: add production configuration #4225
Conversation
/hold We may want to merge konflux-workspaces/workspaces#254 and roll its subsequent release out to staging before merging this. |
94c8e1f
to
0b50141
Compare
/unhold This should be good to review. |
Tests are failing due to an issue with toolchain-e2e, see #4324 for context. |
/retest |
1 similar comment
/retest |
components/workspaces/production/stone-prd-host1/kustomization.yaml
Outdated
Show resolved
Hide resolved
components/workspaces/production/stone-prod-p01/kustomization.yaml
Outdated
Show resolved
Hide resolved
0b50141
to
886ad32
Compare
/hold Wait for #4224 to merge, since it might delete/recreate all resources. |
/retest |
2 similar comments
/retest |
/retest |
/unhold #4224 has merged without any issue. |
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
We need to do a bit of request rewriting, since konflux workspaces doesn't expect /api/k8s/ in its path matching rules, but we should have workspaces act like a part of the k8s api exposed to everyone else. Signed-off-by: Andy Sadler <ansadler@redhat.com>
a953f20
to
871db7b
Compare
/retest |
/retest |
3 similar comments
/retest |
/retest |
/retest |
To run these tests, you'll need to obtain a token corresponding to the environment you're wanting to test. Tokens are not portable, i.e. a token from staging-external won't work for production-external. Internal environments are not yet supported, since the PR for enabling them has not yet landed. See [#4225] for details. [#4225]: redhat-appstudio/infra-deployments#4225 Signed-off-by: Andy Sadler <ansadler@redhat.com>
/retest |
@sadlerap: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
To run these tests, you'll need to obtain a token corresponding to the environment you're wanting to test. Tokens are not portable, i.e. a token from staging-external won't work for production-external. Internal environments are not yet supported, since the PR for enabling them has not yet landed. See [#4225] for details. [#4225]: redhat-appstudio/infra-deployments#4225 Signed-off-by: Andy Sadler <ansadler@redhat.com>
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, hugares, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
805ff13
into
redhat-appstudio:main
To run these tests, you'll need to obtain a token corresponding to the environment you're wanting to test. Tokens are not portable, i.e. a token from staging-external won't work for production-external. Internal environments are not yet supported, since the PR for enabling them has not yet landed. See [#4225] for details. [#4225]: redhat-appstudio/infra-deployments#4225 Signed-off-by: Andy Sadler <ansadler@redhat.com>
To run these tests, you'll need to obtain a token corresponding to the environment you're wanting to test. Tokens are not portable, i.e. a token from staging-external won't work for production-external. Internal environments are not yet supported, since the PR for enabling them has not yet landed. See [#4225] for details. [#4225]: redhat-appstudio/infra-deployments#4225 Signed-off-by: Andy Sadler <ansadler@redhat.com>
No description provided.