Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-platform-controller update #4365

Merged
merged 1 commit into from
Sep 2, 2024
Merged

multi-platform-controller update #4365

merged 1 commit into from
Sep 2, 2024

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Aug 19, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from arewm and hugares August 19, 2024 18:42
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 20, 2024

@rh-tap-build-team[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 7f20640 link false /test appstudio-hac-e2e-tests
ci/prow/appstudio-e2e-tests 7f20640 link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tap-build-team rh-tap-build-team bot force-pushed the multi-platform-controller branch 3 times, most recently from 8eead78 to 24306a6 Compare September 2, 2024 09:04
ifireball
ifireball approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ifireball, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b583ee9 into main Sep 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifireball ifireball ifireball approved these changes

@arewm arewm Awaiting requested review from arewm

@hugares hugares Awaiting requested review from hugares

Assignees

@ifireball ifireball

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ifireball