Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to select component owner #2

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

yangcao77
Copy link
Collaborator

@yangcao77 yangcao77 commented Dec 12, 2023

This PR removes duplicated files and also removes the hard-coded owner from the template and catalog-info.
Instead, added a owner picker to allow user to select component owner from user and group. The catalog registered will be reflected with that owner information

Screenshot 2023-12-12 at 4 10 34 PM

for example, if select guest group, the generated catalog-info.yaml will be with spec:

spec:
  type: service
  owner: group:default/guests 
  lifecycle: experimental

and the catalog registered:
Screenshot 2023-12-08 at 2 05 59 PM

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77
Copy link
Collaborator Author

@jduimovich PTAL. let me know if you have any concerns with this change. Thx!

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Copy link
Contributor

@jduimovich jduimovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine.
In future we will likely need to get the user/owner from whoever is logged into backstage /openshift

@jduimovich jduimovich merged commit 55b11db into redhat-appstudio:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants