Add #!/bin/bash shebang to scripts #65

chmeliik · 2024-07-31T14:57:44Z

When I run ./generate.sh, my machine executes the script via /bin/sh. And yes, /bin/sh is a symlink to /bin/bash. However! As seen in the bash manpage, or in https://tiswww.case.edu/php/chet/bash/POSIX:

When invoked as 'sh', Bash enters POSIX mode after reading the
startup files.

Item 15. in POSIX mode:

Function names must be valid shell 'name's.  That is, they may not
contain characters other than letters, digits, and underscores, and
may not start with a digit.  Declaring a function with an invalid
name causes a fatal syntax error in non-interactive shells.

This causes scripts/update-tekton-definition to fail on

function add-backstage-labels () { ... }

Add explicit #!/bin/bash shebang to all scripts to avoid POSIX/non-POSIX issues.

When I run ./generate.sh, my machine executes the script via /bin/sh. And yes, /bin/sh is a symlink to /bin/bash. However! As seen in the bash manpage, or in https://tiswww.case.edu/php/chet/bash/POSIX: When invoked as 'sh', Bash enters POSIX mode after reading the startup files. Item 15. in POSIX mode: Function names must be valid shell 'name's. That is, they may not contain characters other than letters, digits, and underscores, and may not start with a digit. Declaring a function with an invalid name causes a fatal syntax error in non-interactive shells. This causes scripts/update-tekton-definition to fail on function add-backstage-labels () { ... } Add explicit #!/bin/bash shebang to all scripts to avoid POSIX/non-POSIX issues. Signed-off-by: Adam Cmiel <acmiel@redhat.com>