Update the env var urls for Rekor and TUF #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not confident about this change, but my reasoning for making this PR is that a similar change was made in https://github.com/redhat-appstudio/tssc-sample-pipelines/pull/48/files for the Tekton pipelines. Ref: https://issues.redhat.com/browse/RHTAPBUGS-1280
|
I think the |
Oh yeah. So actually the Jenkins is not local and not in the cluster, hence this still won't work out of the box, even after this change is merged. (I think @jkopriva understood that, I'm just catching up here.) Bottom line: I still think this should be merged, but it doesn't really help with RHTAPBUGS-1280. |
jkopriva
approved these changes
Aug 7, 2024
simonbaird
added a commit
to simonbaird/tssc-sample-templates
that referenced
this pull request
Aug 7, 2024
This change should have been included in redhat-appstudio#69.
|
I forgot these are defined in two places, sorry about that. See #70. |
rhopp
pushed a commit
that referenced
this pull request
Aug 9, 2024
This change should have been included in #69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not confident about this change, but my reasoning for making this PR is that a similar change was made in
https://github.com/redhat-appstudio/tssc-sample-pipelines/pull/48/files for the Tekton pipelines.
FYI @Roming22 @jkopriva .
Ref: https://issues.redhat.com/browse/RHTAPBUGS-1280