Add preflight-lib reference #631

sebrandon1 · 2022-11-02T21:30:45Z

Follow up to #592

Building upon work done by @komish in branch: https://github.com/komish/openshift-preflight/tree/add-lib-ha

Adds the preflight test suite.
Brings in external dependency from openshift-preflight repo.

pkg/provider/operators.go

cnf-certification-test/preflight/suite.go

Serialize the merged kube config into a temporary file and save the file path so it can be read on demand. This could be used by Brandon's wip redhat-best-practices-for-k8s#631 for the preflight lib integration.

greyerof

I've seen in the log output from the preflight checks that they're using tmp folders to create some files... we might have the same issue as in #644:

cnf-certification-test/preflight/suite.go

* Created merged kube config file in the clientsholder. Serialize the merged kube config into a temporary file and save the file path so it can be read on demand. This could be used by Brandon's wip #631 for the preflight lib integration. * Add app's directory as alternative for temp files.

sebrandon1 · 2022-11-16T22:19:31Z

Removing the proof of concept label. The refactor PR merged today and I have updated this PR to point at it.

redhat-openshift-ecosystem/openshift-preflight#825

This PR above merged into an upstream branch called lib but is still accessible via a go mod replace directive.

sebrandon1 · 2022-11-16T22:31:12Z

I'm currently checking through these failures:

Summarizing 4 Failures:
  [FAIL] preflight [It] preflight-HasUniqueTag [common, preflight, preflight-HasUniqueTag]
  /Users/bpalm/Repositories/go/src/github.com/test-network-function/cnf-certification-test/pkg/testhelper/testhelper.go:82
  [FAIL] preflight [It] preflight-RunAsNonRoot [common, preflight, preflight-RunAsNonRoot]
  /Users/bpalm/Repositories/go/src/github.com/test-network-function/cnf-certification-test/pkg/testhelper/testhelper.go:82
  [FAIL] preflight [It] preflight-HasLicense [common, preflight, preflight-HasLicense]
  /Users/bpalm/Repositories/go/src/github.com/test-network-function/cnf-certification-test/pkg/testhelper/testhelper.go:82
  [FAIL] preflight [It] preflight-DeployableByOLM [common, preflight, preflight-DeployableByOLM]
  /Users/bpalm/Repositories/go/src/github.com/test-network-function/cnf-certification-test/pkg/testhelper/testhelper.go:82

sebrandon1 · 2023-02-06T18:38:15Z

For reviewers, do we have a preference if these preflight tests should be tagged TagCommon? What about how we classify them as telco/non-telco/etc @mwlinca?

ramperher · 2023-02-07T07:26:43Z

For reviewers, do we have a preference if these preflight tests should be tagged TagCommon? What about how we classify them as telco/non-telco/etc @mwlinca

From my point of view, until having an official resolution about how tnf and preflight will be tested, I would use a separate label for preflight, not including it within the common label

…egration build-depends: redhat-best-practices-for-k8s/certsuite#631 Test-App-Hints: tnf_test_example Test-App-Args-Hints: -e {"dci_components_by_query":["type:tnf_test_example"]} -e do_cnf_cert=true -e {"tnf_config":[{"namespace":"test-cnf","targetpodlabels":["environment=test"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"mongodb-enterprise","exclude_connectivity_regexp":""},{"namespace":"production-cnf","targetpodlabels":["environment=production"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"","exclude_connectivity_regexp":""}]} -e test_network_function_version="HEAD" -e partner_creds=/opt/cache/partner_config.json -e dci_teardown_on_failure=false -e {"tnf_env_vars":{"TNF_NON_INTRUSIVE_ONLY":"false","TNF_RUN_CFD_TEST":"false","TNF_LOG_LEVEL":"debug","TNF_ALLOW_PREFLIGHT_INSECURE":"true"}} Change-Id: Ib8d32cbcf6f94b1e09ec354dac94d55412cba67e

sebrandon1 · 2023-02-09T21:40:00Z

/dci-rerun

cnf-certification-test/preflight/suite.go

pkg/provider/containers.go

cnf-certification-test/preflight/suite.go

pkg/provider/operators.go

cnf-certification-test/preflight/suite.go

Add operator support Add unit test for container results Use provided structs from lib Switch to new funcs work on cacheing Add local Dockerfile Controller-runtime upgrade Modify scripts to mount docker config Remove skipIfAny Modify scripts to mount docker config Add allow preflight insecure variable Add .json to config var

pkg/provider/containers.go

…preflight Patch needed for redhat-best-practices-for-k8s/certsuite#804 and redhat-best-practices-for-k8s/certsuite#631. When running tnf HEAD version: - check if partner_creds variable is provided, else print a warning message - prepare dockercfg file for tnf - provide dockercfg file to tnf when using HEAD patch already validated in connected env without PR804: https://www.distributed-ci.io/jobs/ba15b3a0-a544-491a-b5c8-604cf83ef52a/jobStates?sort=date now testing the patch with PR804 build-depends: redhat-best-practices-for-k8s/certsuite#804 Test-App-Hints: tnf_test_example Test-App-Args-Hints: -e {"dci_components_by_query":["type:tnf_test_example"]} -e do_cnf_cert=true -e {"tnf_config":[{"namespace":"test-cnf","targetpodlabels":["environment=test"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"mongodb-enterprise","exclude_connectivity_regexp":""},{"namespace":"production-cnf","targetpodlabels":["environment=production"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"","exclude_connectivity_regexp":""}]} -e {"tnf_env_vars":{"TNF_NON_INTRUSIVE_ONLY":"false","TNF_RUN_CFD_TEST":"false","TNF_LOG_LEVEL":"debug"}} -e test_network_function_version=HEAD -e partner_creds=/opt/cache/partner_config.json Change-Id: I3393fca5b002be7cfcace89da2ed8364ffea8ae3

…egration build-depends: redhat-best-practices-for-k8s/certsuite#631 Test-App-Hints: tnf_test_example Test-App-Args-Hints: -e {"dci_components_by_query":["type:tnf_test_example"]} -e do_cnf_cert=true -e {"tnf_config":[{"namespace":"test-cnf","targetpodlabels":["environment=test"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"mongodb-enterprise","exclude_connectivity_regexp":""},{"namespace":"production-cnf","targetpodlabels":["environment=production"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"","exclude_connectivity_regexp":""}]} -e test_network_function_version="HEAD" -e partner_creds=/opt/cache/partner_config.json -e dci_teardown_on_failure=false -e {"tnf_env_vars":{"TNF_NON_INTRUSIVE_ONLY":"false","TNF_RUN_CFD_TEST":"false","TNF_LOG_LEVEL":"debug","TNF_ALLOW_PREFLIGHT_INSECURE":"true"}} Change-Id: Ib8d32cbcf6f94b1e09ec354dac94d55412cba67e

…preflight Patch needed for redhat-best-practices-for-k8s/certsuite#804 and redhat-best-practices-for-k8s/certsuite#631. When running tnf HEAD version: - check if partner_creds variable is provided, else print a warning message - prepare dockercfg file for tnf - provide dockercfg file to tnf when using HEAD patch already validated in connected env without PR804: https://www.distributed-ci.io/jobs/ba15b3a0-a544-491a-b5c8-604cf83ef52a/jobStates?sort=date now testing the patch with PR804 build-depends: redhat-best-practices-for-k8s/certsuite#804 Test-App-Hints: tnf_test_example Test-App-Args-Hints: -e {"dci_components_by_query":["type:tnf_test_example"]} -e do_cnf_cert=true -e {"tnf_config":[{"namespace":"test-cnf","targetpodlabels":["environment=test"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"mongodb-enterprise","exclude_connectivity_regexp":""},{"namespace":"production-cnf","targetpodlabels":["environment=production"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"","exclude_connectivity_regexp":""}]} -e {"tnf_env_vars":{"TNF_NON_INTRUSIVE_ONLY":"false","TNF_RUN_CFD_TEST":"false","TNF_LOG_LEVEL":"debug"}} -e test_network_function_version=HEAD -e partner_creds=/opt/cache/partner_config.json Change-Id: I3393fca5b002be7cfcace89da2ed8364ffea8ae3

…egration build-depends: redhat-best-practices-for-k8s/certsuite#631 Test-App-Hints: tnf_test_example Test-App-Args-Hints: -e {"dci_components_by_query":["type:tnf_test_example"]} -e do_cnf_cert=true -e {"tnf_config":[{"namespace":"test-cnf","targetpodlabels":["environment=test"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"mongodb-enterprise","exclude_connectivity_regexp":""},{"namespace":"production-cnf","targetpodlabels":["environment=production"],"target_crds":["crdexamples.test-network-function.com"],"operators_regexp":"","exclude_connectivity_regexp":""}]} -e test_network_function_version="HEAD" -e partner_creds=/opt/cache/partner_config.json -e dci_teardown_on_failure=false -e {"tnf_env_vars":{"TNF_NON_INTRUSIVE_ONLY":"false","TNF_RUN_CFD_TEST":"false","TNF_LOG_LEVEL":"debug","TNF_ALLOW_PREFLIGHT_INSECURE":"true"}} Change-Id: Ib8d32cbcf6f94b1e09ec354dac94d55412cba67e

sebrandon1 added work in progress Proof of concept labels Nov 2, 2022

sebrandon1 self-assigned this Nov 2, 2022

sebrandon1 mentioned this pull request Nov 2, 2022

Add preflight-lib reference #592

Closed

sebrandon1 force-pushed the preflight_lib_ha branch from 7b990db to 0647d53 Compare November 3, 2022 17:58

sebrandon1 mentioned this pull request Nov 3, 2022

Add default values for catalog entries #634

Merged

sebrandon1 force-pushed the preflight_lib_ha branch from 0647d53 to 83acdbe Compare November 3, 2022 18:10

greyerof reviewed Nov 4, 2022

View reviewed changes

pkg/provider/operators.go Outdated Show resolved Hide resolved

cnf-certification-test/preflight/suite.go Outdated Show resolved Hide resolved

sebrandon1 force-pushed the preflight_lib_ha branch 2 times, most recently from 06aa033 to 7699a25 Compare November 4, 2022 15:12

greyerof mentioned this pull request Nov 7, 2022

Created merged kube config file in the clientsholder. #644

Merged

sebrandon1 force-pushed the preflight_lib_ha branch 2 times, most recently from f1c7efc to 97743d9 Compare November 7, 2022 22:54

greyerof reviewed Nov 8, 2022

View reviewed changes

cnf-certification-test/preflight/suite.go Show resolved Hide resolved

sebrandon1 force-pushed the preflight_lib_ha branch 4 times, most recently from a58be1c to 359c12e Compare November 14, 2022 16:27

sebrandon1 force-pushed the preflight_lib_ha branch 4 times, most recently from 1c3d3fb to e4b9ccc Compare November 16, 2022 22:00

sebrandon1 removed the Proof of concept label Nov 16, 2022

sebrandon1 force-pushed the preflight_lib_ha branch 3 times, most recently from b638692 to c0cf4da Compare November 18, 2022 15:10

sebrandon1 requested review from aabughosh, bnshr and shimritproj February 6, 2023 18:36

shimritproj approved these changes Feb 9, 2023

View reviewed changes

sebrandon1 force-pushed the preflight_lib_ha branch 2 times, most recently from f999e48 to b40a024 Compare February 9, 2023 17:21

jmontesi reviewed Feb 10, 2023

View reviewed changes

sebrandon1 force-pushed the preflight_lib_ha branch 3 times, most recently from da18b88 to b253f9d Compare February 10, 2023 21:51

jmontesi approved these changes Feb 13, 2023

View reviewed changes

sebrandon1 force-pushed the preflight_lib_ha branch 2 times, most recently from 68cb1cf to a574ee7 Compare February 13, 2023 14:53

sebrandon1 added 2 commits February 13, 2023 11:26

Address comments from Juan

03a22df

edcdavid reviewed Feb 14, 2023

View reviewed changes

pkg/provider/containers.go Show resolved Hide resolved

Add logging from preflight LIBRARY.md file suggestion

f644edd

sebrandon1 force-pushed the preflight_lib_ha branch from a574ee7 to f644edd Compare February 14, 2023 17:51

Fix linter funlen entries

16bfc2b

edcdavid approved these changes Feb 14, 2023

View reviewed changes

sebrandon1 merged commit ba59e0a into redhat-best-practices-for-k8s:main Feb 14, 2023

sebrandon1 deleted the preflight_lib_ha branch February 14, 2023 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add preflight-lib reference #631

Add preflight-lib reference #631

sebrandon1 commented Nov 2, 2022 •

edited by ramperher

Loading

greyerof left a comment

sebrandon1 commented Nov 16, 2022

sebrandon1 commented Nov 16, 2022

sebrandon1 commented Feb 6, 2023

ramperher commented Feb 7, 2023

sebrandon1 commented Feb 9, 2023

Add preflight-lib reference #631

Add preflight-lib reference #631

Conversation

sebrandon1 commented Nov 2, 2022 • edited by ramperher Loading

greyerof left a comment

Choose a reason for hiding this comment

sebrandon1 commented Nov 16, 2022

sebrandon1 commented Nov 16, 2022

sebrandon1 commented Feb 6, 2023

ramperher commented Feb 7, 2023

sebrandon1 commented Feb 9, 2023

sebrandon1 commented Nov 2, 2022 •

edited by ramperher

Loading