Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dry-run when running helm template #268

Merged

Conversation

mmulholla
Copy link
Collaborator

Set dry-run when running helm template for the certified images check. This ensure the chart kubeVersion is checked against the install cluster and not the helm client default:

see: https://issues.redhat.com/browse/HELM-370

Note: Existing regression run is sufficient test.

Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dperaza4dustbit dperaza4dustbit merged commit d0b1bec into redhat-certification:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants