Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool fails when chart contains ci directory #346

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

fenech
Copy link
Contributor

@fenech fenech commented May 8, 2023

The function used to merge the CI overrides expects a pointer and so the test fails:

--- FAIL: TestChartTesting (1.55s)
    --- FAIL: TestChartTesting/a_valid_chart_with_ci_override_values_should_succeed (0.00s)
        /home/tom/dev/chart-verifier/internal/chartverifier/checks/charttesting_test.go:78: 
            	Error Trace:	charttesting_test.go:78
            	Error:      	Not equal: 
            	            	expected: "Chart tests have passed"
            	            	actual  : "creating temporary values file: merging extra values: dst must be a pointer"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-Chart tests have passed
            	            	+creating temporary values file: merging extra values: dst must be a pointer
            	Test:       	TestChartTesting/a_valid_chart_with_ci_override_values_should_succeed

@fenech fenech force-pushed the bugfix/chart-ci-directory branch from a958f96 to 8e05c5b Compare May 8, 2023 14:29
@fenech fenech marked this pull request as ready for review May 8, 2023 14:36
@fenech
Copy link
Contributor Author

fenech commented May 9, 2023

Checks are failing due to something that seems unrelated:

error: dial tcp: lookup api.cert-test.64w3.p1.openshiftapps.com: no such host - verify you have provided the correct host and port and that the server is currently running.

@komish komish closed this Jun 1, 2023
@komish komish reopened this Jun 1, 2023
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @fenech for finding and fixing this bug!

@komish komish merged commit f149ef4 into redhat-certification:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants