Support managed_disk_type #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p3ck
force-pushed
the
managed_disk_type
branch
2 times, most recently
from
fea2fe7 to
942924a
Compare
p3ck
force-pushed
the
managed_disk_type
branch
from
942924a to
cc71ad0
Compare
p3ck
force-pushed
the
managed_disk_type
branch
2 times, most recently
from
e8bc655 to
aec7c1d
Compare
anna-savina
reviewed
Jan 23, 2025
| @@ -93,8 +107,6 @@ argument_specs: | |||
| description: | |||
| - Initial disk size in GB for blank data disks. Cannot be larger than 1023 GB. | |||
| - Can only be modified when VM is deallocated. | |||
| managed_disk_type: | |||
There was a problem hiding this comment.
data_disks.managed_disk_type is valid argument
There was a problem hiding this comment.
lun, caching, disk_size_gb, managed_disk_type, storage_account_name, storage_blob_name, storage_container_name are related to data_disks. Should they be data_disk options?
|
No description of managed_disk_type var for OS disk in README.md. |
Add support for specifying managed_disk_type. This is a prerequisite for supporting snapshots. Also fixed variable names to include role prefix to prevent variable collisions. fixes redhat-cop#99
p3ck
force-pushed
the
managed_disk_type
branch
from
aec7c1d to
06ad93a
Compare
anna-savina
approved these changes
Jan 26, 2025
amitosw15
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying managed_disk_type. This is a prerequisite for supporting snapshots.
fixes #99