Add new azure_manage_snapshot role #101
Conversation
p3ck
force-pushed
the
manage_snapshot
branch
3 times, most recently
from
2ea87b9 to
bd5e95e
Compare
p3ck
force-pushed
the
manage_snapshot
branch
2 times, most recently
from
1d498e9 to
1b075d5
Compare
|
Looks like we either need to exclude tests/integration/targets/azure_ops_test_azure_virtual_machine_with_public_ip/tasks/delete_all_resources.yml from lint or FQCN the tasks there. Thanks for the fixes so far, this should be the last one needed. |
| @@ -0,0 +1,3 @@ | |||
| - name: Create, delete or restore Snapshot | |||
There was a problem hiding this comment.
Maybe it's worth adding a check that mandatory variables are defined before starting?
There was a problem hiding this comment.
I thought the idea of the argument_spec.yml was supposed to enforece this.
| @@ -0,0 +1,59 @@ | |||
| --- | |||
There was a problem hiding this comment.
Other tests are run from tasks/main.yml. Not sure that the current structure can be run with the existing Jenkins job.
There was a problem hiding this comment.
We should be launching the tests the same way as ansible upstream does.
ansible-test integration azure_ops_test_azure_manage_snapshot
Why is jenkins doing it differently?
| tasks: | ||
| - name: Include default variables | ||
| ansible.builtin.include_vars: | ||
| file: ../vars/vars.yml |
There was a problem hiding this comment.
You could use defaults/main.yml for default variables, so you don’t need an additional task.
There was a problem hiding this comment.
I cannot use defaults/main.yml because this is running as a playbook.
| @@ -0,0 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
no runme.sh in other integration tests
There was a problem hiding this comment.
This is normal if you need to split the tests between different hosts. The azure snapshot operations have to happen from localhost and to validate the snapshot operations have to happen on the VirtualMachine under test.
This is the accepted way to do this under ansible-test
There was a problem hiding this comment.
I see. Ok. I'll check tomorrow if the existing Jenkins job works with playbooks
tests/integration/targets/azure_ops_test_azure_manage_snapshot/tasks/create_snapshot.yml
Outdated
Show resolved
Hide resolved
p3ck
force-pushed
the
manage_snapshot
branch
2 times, most recently
from
cbc885a to
aeae51e
Compare
New role azure_manage_snapshot will help in creating, restoring and deleting snapshots.
|
I don't understand the ansible-lint failure. We have the .ansible-lint file that says to ignore tests/integration dir and it did ignore it in another PR.. but now it's back. |
I think this was because the profile was wrong. I changed it to shared and it seems good |
New role azure_manage_snapshot will help in creating, restoring and deleting snapshots.