Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish updating the role_prefix #55

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

p3ck
Copy link
Contributor

@p3ck p3ck commented Mar 7, 2024

The update to move to role_prefix was incomplete.
There was also an issue with the networking_stack that was fixed as well.

@p3ck p3ck mentioned this pull request Mar 7, 2024
README.md Outdated Show resolved Hide resolved
@p3ck p3ck force-pushed the update_prefix branch 3 times, most recently from 475fd52 to 4fc2de7 Compare March 11, 2024 12:46
@p3ck
Copy link
Contributor Author

p3ck commented Mar 11, 2024

rebased and updated the changelog to match.

Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a minor change

playbooks/roles/scale_virtual_machine/tasks/main.yml Outdated Show resolved Hide resolved
The update to move to role_prefix was incomplete.
There was also an issue with the networking_stack that was fixed as
well.
@abikouo abikouo merged commit aa828d1 into redhat-cop:main Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants