Make python requirements more obvious #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-savina
reviewed
Oct 13, 2024
| It is common for people to use `localhost` to run the tasks in this content since most tasks simply interact with the vSphere environment. If you do not use the execution environment, the following requirements are needed on whatever host runs the tasks: | ||
| ### Python Requirements | ||
|
|
||
| It is common for people to use `localhost` to run the tasks in this content since most tasks simply interact with the vSphere environment. If you do not use the execution environment mentioned above, the following requirements are needed on whatever host runs the tasks: | ||
| - Python 3.9 or greater | ||
| - Python requirements found in [execution-environment/requirements.txt](https://github.com/redhat-cop/cloud.vmware_ops/tree/main/execution-environment/requirements.txt) |
There was a problem hiding this comment.
for integration tests used another requirements.txt (https://github.com/redhat-cop/cloud.vmware_ops/blob/main/tests/integration/requirements.txt). Should it be the same?
There was a problem hiding this comment.
I dont think it should be the same.
It looks like there is a lot of overlap between the two which probably isnt great. Maybe during test setup we should install the requirements from the EE directory first and then the requirements.txt in the tests directory can be anything else that just the tests need. For example, podman is just needed by the integration tests and would not make sense for a regular user to install
Ill make a ticket for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is feedback from the testathon.
The python requirements for this collection are not listed on the Hub dependency page. We cant control that but we can make it more obvious in the collection readme/main documentation where python requirements are documented and can be found.