Multi cluster promotion #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; needs more work
|
@pabrahamsson this is ready to be re-tested and reviewed. @sabre1041 since there are a lot of new Jenkinsfile elements in this one, it would be worth another code review. |
sabre1041
requested changes
Feb 23, 2018
| ``` | ||
| The Ansible automation for your _Dev_ cluster will expect a parameters file to be created at `./applier/params/prod-credentials`. It should look something like this: | ||
| ``` | ||
| $ echo "TOKEN=${TOKEN} |
There was a problem hiding this comment.
Do we want to add more context on how to retrieve these values? Such as the registry?
There was a problem hiding this comment.
@sabre1041 until we have a consistent way to grab the registry URL, i think there's not point.
multi-cluster-spring-boot/README.md
Outdated
|
|
||
| This quickstart can be deployed quickly using Ansible. Here are the steps. | ||
|
|
||
| 1. Clone [this repo](https://github.com/redhat-cop/container-pipelines.git) and the [casl-ansible](https://github.com/redhat-cop/casl-ansible.git) repo. |
There was a problem hiding this comment.
To align with the examples in containers-quickstarts, let's throw a requirements.yml that will bring in any required dependencies
|
@sabre1041 addressed changes |
sabre1041
approved these changes
Feb 28, 2018
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an example pipeline that includes cross-cluster promotion.
Completes https://trello.com/c/b5NaGDBV/48-build-a-multi-cluster-pipeline
@redhat-cop/developer-workflow