Add wait for Tower API in config-ansible-tower-ocp-ldap-ca role #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAHDTech
force-pushed
the
feature/tower-api-wait
branch
from
0a2c496 to
c3bb4eb
Compare
MAHDTech
force-pushed
the
feature/tower-api-wait
branch
from
e934b11 to
f66e7c3
Compare
oybed
reviewed
Oct 13, 2021
roles/ansible/tower/config-ansible-tower-ocp-ldap-ca/tasks/ocp_set_ca_certificate.yml
Outdated
Show resolved
Hide resolved
jfilipcz
pushed a commit
to jfilipcz/infra-ansible
that referenced
this pull request
Oct 20, 2021
…at-cop#653) * Add a wait for Tower API * Use existing role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a check that the Tower API is available before ending the role to ensure that any following roles that depend on the API being available will work.
How should this be tested?
Run the role
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc.
On slower environments there is a race condition where the Deployment reports as being Ready due to passing healthcheck but the API is not ready to serve requests.
People to notify
cc: @redhat-cop/infra-ansible