Add support for custom packages list in 'manage-haproxy' role #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce lb_install_packages list * Defaults point to packages list valid for Centos7
oybed
reviewed
Apr 18, 2022
| - python3-firewall | ||
| - libsemanage-python | ||
| - policycoreutils-python | ||
| loop: '{{ lb_install_packages|flatten(levels=-1) }}' |
There was a problem hiding this comment.
the loops isn't necessary anymore now that package actually takes a single string or a list of packages to install - hence you can just feed the lb_install_packages to the name parameter above
|
In general, this change is fine. However, the role was just updated to work with RHEL8 as-is [1], so the existing content isn't a CentOS7 supported install (it may still work on CentOS7, but not tested). As the goal of the new releases of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes hard-coded list of packages to be installed on LB, in favor of configurable list.
Default list holds packages list valid for Centos7
How should this be tested?
Run the role with supplied defaults
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc.
N/A
People to notify
cc: @redhat-cop/infra-ansible