-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten label on some loops to show name instead of entire json block #1002
Conversation
There are other roles that are also showing the full JSON output as part of the label. If this shortened version is acceptable, I'm willing to open future PRs to similarly update them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. However before accepting it would be good to apply the same change to all the roles if you're happy to do so? I'd like to see that to ensure there is consistency throughout
Thanks for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a changelog fragment with a summary of the change
I'm still moving into this collection and only doing the controller section. I'm happy to update the controller roles as I run across them, and while I'll be using most of them, I'm not necessarily using all that may need updated. I'll continue working through them and add a changelog fragment |
The current label of the step to wait for the async job templates to complete shows the full JSON output of the job var, which is very verbose and can be especially long when a survey is included. Shorten the output so it only shows the name of the job template, very similar to the task that manages controller job templates
Updated all instances that I found in my testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog fragments can be a list of each one changed, if that makes things easier, let us know when you want to merge this, thanks for the work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed other tasks to improve loop label
Are the fragments ok as they are now with separate files reflecting which role they relate to, or do you want only a single file with a list of the change on each role? I'm not sure how to mark Tompage1994's requested changes as complete |
The fragments could be one file or kept as is, I think his point was just an FYI so you know that you don't have to create multiple files. @Tompage1994 needs to approve that you made the requested changes, there is nothing you can do on your side. |
The current label of the step to wait for the async job templates to complete shows the full JSON output of the job var, which is very verbose and can be especially long when a survey is included.
Shorten the output so it only shows the name of the job template, very similar to the task that manages controller job templates
What does this PR do?
The current label of the step to wait for the async job templates to complete shows the full JSON output of the job var, which is very verbose and can be especially long when a survey is included.
Shorten the output so it only shows the name of the job template, very similar to the task that manages controller job templates
Sample of current very verbose output from a single job template
After this change to only show the Job Template name
How should this be tested?
Is there a relevant Issue open for this?
resolves #[number]
Other Relevant info, PRs, etc