Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btrfs bigboot #72

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Btrfs bigboot #72

merged 5 commits into from
Jul 11, 2024

Conversation

swapdisk
Copy link
Member

@swapdisk swapdisk commented Jul 3, 2024

This PR introduces support for using the bigboot role to increase the size of a boot partition on a host using Btrfs filesystems. Previously, only hosts with LVM were supported.

Fixes #68, although I'm going to pass on the suggestion of renaming the collection.

This is mostly a rewrite of the bigboot pre-mount hook. Previously, the LVM changes using pvmove and pvresize were done by the hook during the reboot. However, there is no reason these can't be done using Ansible on the running OS before the reboot. Removing the LVM bits greatly simplifies the pre-mount hook script. With this implementation, the new Btrfs changes or the old LVM changes are done by tasks included from prep_btrfs.yml or prep_lvm.yml, depending on if the next partition after boot is Btrfs or LVM.

The new script also fixes some issues with the progress output logged by the hook. It no longer uses /dev/kmsg which proved to be troublesome if there were very long error messages. The output is now seen on the console even if the quiet kernel command line arg is set. The log outputs also can be easily seen after the reboot using journalctl as demonstrated in the updated README file.

Copy link
Collaborator

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapdisk swapdisk merged commit b006c47 into redhat-cop:main Jul 11, 2024
15 checks passed
@swapdisk swapdisk deleted the btrfs_bigboot branch July 11, 2024 15:09
@Conan-Kudo
Copy link

Works for me too. Thanks for this! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants