Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial operatorhub templates #64

Merged

Conversation

tylerauerbeck
Copy link
Contributor

What is this PR About?

This adds some initial templates for interacting with OperatorHub. This assumes that OLM is running and configured appropriately.

How do we test this?

Test by deploying the Elasticsearch operator on OCP 4:

oc new-project my-namespace

oc process -f operatorgroup.yaml -p NAME=openshift-logging-operatorgroup -p TARGET_NAMESPACE=my-namespace| oc apply -f - -n my-namespace

oc process -f catalogsourceconfig.yml -p NAME=elasticsearch-operator -p OPERATORS="elasticsearch-operator" | oc apply -f - -n openshift-marketplace

oc process -f subscription.yaml -p NAME=elasticsearch-operator -p OPERATOR_NAME=elasticsearch-operator -p OPERATOR_NAMESPACE=openshift-operators -p CATALOG_SOURCE_NAME=elasticsearch-operator | oc apply -f - -n openshift-operators

cc: @redhat-cop/day-in-the-life

Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tylerauerbeck, two minor comments inline.

kind: Subscription
metadata:
name: "${NAME}"
namespace: "${OPERATOR_NAMESPACE}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should be removed and instead set the namespace from cli or from the applier.

operatorhub/README.md Outdated Show resolved Hide resolved
@tylerauerbeck
Copy link
Contributor Author

@pabrahamsson Fixed. Let me know what you think.

Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pabrahamsson pabrahamsson merged commit 65ff835 into redhat-cop:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants