Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding namespace-has-resourcequota policy #101

Merged

Conversation

deweya
Copy link
Contributor

@deweya deweya commented Aug 3, 2020

What is this PR About?

Adds namespace-has-resourcequota. Closes #55

Check list

  • Have you created a test case in _test/conftest-unittests.sh
  • Have you created a test case in _test/opa-profile.sh
  • Have you created a test case in _test/gatekeeper-integrationtests.sh
  • Have you followed the TESTING.md doc? If not, please provide commands/steps to test this PR.
  • Have you re-generated POLICIES.md

The other namespace-has-* policy didn't have a test case in _test/opa-profile.sh or _test/gatekeeper-integrationtests.sh, so I didn't add tests there since this one is similar.

cc: @redhat-cop/rego-policies

@deweya
Copy link
Contributor Author

deweya commented Aug 3, 2020

/assign @etsauer

@garethahealy
Copy link
Contributor

@deweya ; can you:

  • rebase
  • GO111MODULE=on go get github.com/plexsystems/konstraint
  • konstraint doc -o POLICIES.md

that should fix the CI.

Copy link
Contributor

@garethahealy garethahealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just needs CI fixing.

@deweya deweya force-pushed the feat/namespace-resourcequotas branch from 8196784 to 539e18f Compare August 4, 2020 14:32
@deweya deweya force-pushed the feat/namespace-resourcequotas branch from 539e18f to 7fc86d3 Compare August 4, 2020 14:38
@deweya
Copy link
Contributor Author

deweya commented Aug 4, 2020

@garethahealy Fixed the CI. That policy regen is cool stuff

@garethahealy
Copy link
Contributor

/lgtm
/approve

@redhat-cop-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deweya, garethahealy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-cop-ci-bot redhat-cop-ci-bot merged commit 1704a69 into redhat-cop:master Aug 4, 2020
@deweya deweya deleted the feat/namespace-resourcequotas branch August 4, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespaces have ResourceQuotas
4 participants