Added policies warn-k8s-namespace-conftestcombine-bestpractices #27
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garethahealy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| manifests[i].kind == "Namespace" | ||
| namespace := manifests[i] | ||
|
|
||
| not namespaceHasNetworkPolicy(namespace, manifests) |
There was a problem hiding this comment.
@garethahealy - does namespace := manifests[i] pop the item out of the array so it's no longer in manifests ?
There was a problem hiding this comment.
no, just sets the var - I just do that to make it easier to read
There was a problem hiding this comment.
oh ok - so namespace is not needed in your function below
There was a problem hiding this comment.
not currently, but if the policy was to be extended to match selectors, then yep it would
There was a problem hiding this comment.
That's grand, i'll merge this one in now so.
|
/lgtm |
What is this PR About?
Split out: #19
How do we test this?
See the action
cc: @redhat-cop/rego-policies