Added warn-k8s_ocp-deployment_deploymentconfig-bestpractices #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
springdo
reviewed
Jun 24, 2020
|
|
||
| input.apiVersion == apis[_] | ||
| input.kind == kinds[_] | ||
| input.spec.replicas % 2 == 0 |
springdo
reviewed
Jun 24, 2020
| kinds := ["Deployment", "DeploymentConfig"] | ||
|
|
||
| input.apiVersion == apis[_] | ||
| input.kind == kinds[_] |
There was a problem hiding this comment.
These above lines are repeated loads, they could probs be abstracted into a function right?
There was a problem hiding this comment.
@springdo yep, we can reduce some duplication by creating utils rego files and importing them as 'data'
There was a problem hiding this comment.
I'll raise an issue for that, we can tackle it separately to this monster 🙈
springdo
approved these changes
Jun 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garethahealy, springdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
More splitting: #19
How do we test this?
Action output green
cc: @redhat-cop/rego-policies