Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated kinds annotation to be lower case #91

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Updated kinds annotation to be lower case #91

merged 1 commit into from
Jul 27, 2020

Conversation

garethahealy
Copy link
Contributor

What is this PR About?

Konstraint now expects the kind annotation to be lowercase.

How do we test this?

Check the generated constraint.yaml includes the kinds key. i.e.:

apiVersion: constraints.gatekeeper.sh/v1beta1
kind: ContainerVolumemountInconsistentPath
metadata:
  name: containervolumemountinconsistentpath
spec:
  match:
    kinds:
    - apiGroups:
      - apps.openshift.io
      - apps
      kinds:
      - DeploymentConfig
      - DaemonSet
      - Deployment
      - StatefulSet

cc: @redhat-cop/rego-policies

@redhat-cop-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethahealy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckavili
Copy link
Contributor

ckavili commented Jul 27, 2020

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants