Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt and helm chart #25

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Conversation

raffaelespazzoli
Copy link
Collaborator

added tilt
fixed helm chart generation
fixes #22 again

Signed-off-by: raffaelespazzoli raffaele.spazzoli@gmail.com

fixed helm chart generation

Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
@raffaelespazzoli
Copy link
Collaborator Author

fixes #23

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the same comment on Podman as noted here

f
Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
@raffaelespazzoli
Copy link
Collaborator Author

@sabre1041 done

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit e0efa5b into redhat-cop:main Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Server Name in Service Monitor of Volume Expander Operator
2 participants