Test operator source

[pmacik]

This PR:

• Adds a make target (test-operator-source) to execute a simple test for verifying that the operator is successfully installed from application registry on Quay.io.

It is a functional test for OperatorSource. The files included in the pull request define the OperatorSource itself and it's corresponding CatalogSource, and Subscription.

It depends on the push-operator-app-registry make target from #174 that creates a CSV for the operator and pushes it to quay.io. The test-operator-source make target runs the test to verify the creation of the Subscription, InstallPlan, and verifies that the operator's pod has started.

[pmacik]

This PR replaces and extends the #135.

[ldimaggi]

Small syntax error in make file:

Line 106 should be:

$(eval INSTALL_PLAN := $(shell oc get sub devconsole -n openshift-operators -o jsonpath='{.status.installplan.name}'))

[ldimaggi]

I'd also be interested in seeing the state of the pod - so that the test will cover these steps:

.PHONY: test-operator-source
test-operator-source: push-operator-app-registry
	$(eval OPSRC_NAME := devconsole-operators-$(TAG))
	$(Q)oc project openshift-marketplace 
	$(Q)sed -e "s,REPLACE_NAMESPACE,$(DEVCONSOLE_APPR_NAMESPACE)," ./test/opsrc/operator_source.yaml | sed -e "s,REPLACE_OPERATOR_SOURCE_NAME,$(OPSRC_NAME)," | oc apply -f -
	$(Q)oc apply -f ./test/opsrc/catalog_source.yaml
	$(Q)oc apply -f ./test/opsrc/subscription.yaml
	$(Q)oc get sub devconsole -n openshift-operators
	$(eval INSTALL_PLAN := $(shell oc get sub devconsole -n openshift-operators -o jsonpath='{.status.installplan.name}'))
	$(Q)oc get installplan $(INSTALL_PLAN) -n openshift-operators
	$(Q)oc get pods  -l name=devconsole-operator -n openshift-operators -o jsonpath='{.items[*].status.phase}{"\n"}'
	$(Q)go test -vet off ${V_FLAG} $(shell go list ./... | grep /test/opsrc) -failfast

We will want to wrap the actual test steps in Go so that the perform asserts.

simple_test.zip

[sbose78]

/retest

[sbose78]

Add a description please :)

[ldimaggi]

Add a description please :)

This pull request implements a functional test for OperatorSource. The files included in the pull request define the Operator Source, it's corresponding CatalogSource, and Subscription.

The push-operator-app-registry make target creates the OperatorSouce and pushes the Operator to quay.io. The test-operator-source make target runs the test to verify the creation of the OperatirSubscription, install plan, and verifies that the Operator's pod has started.

[pmacik]

@sbose78, @ldimaggi: I updated the PR's description.

[ldimaggi]

Final changes LGTM.

[sbose78]

Nice work @pmacik and @ldimaggi !

[baijum]

/ok-to-test

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum, ldimaggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baijum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment