follow-up for dotnet-trace #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omajid
reviewed
Oct 2, 2023
omajid
reviewed
Oct 2, 2023
omajid
reviewed
Oct 2, 2023
tmds
reviewed
Oct 3, 2023
tmds
reviewed
Oct 3, 2023
|
@nicrowe00 fyi, the trace files generated by the tool can be read using https://www.nuget.org/packages/Microsoft.Diagnostics.Tracing.TraceEvent/. There's an example in this blog post that shows how to use the library for reading a trace file: https://developers.redhat.com/blog/2019/12/23/tracing-net-core-applications. I'm ok with validating the output of the topN because that will read the trace to create a summary. |
Rewriting a portion of the test for dotnet-trace, specifically dealing with the 'report' command. Instead of verifying that the report log file exists, the test now checks the output of the command to verify that a specific method is on the callstack. Signed-off-by: Niall Crowe <nicrowe@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting a portion of the test for dotnet-trace, specifically dealing with the 'report' command. Instead of verifying that the report log file exists, the test now checks the output of the command to verify that a specific method is on the callstack.