feat: Support use of secrets for Route tls data #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
svghadi
force-pushed
the
route-tls-secret
branch
from
96d2c19 to
191bb4f
Compare
svghadi
changed the title
|
/retest |
anandf
reviewed
Nov 4, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4690e5b
into
redhat-developer:master
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR adds support to use secrets to configure tls data in ArgoCD CR. The feature is implemented in upstream operator with argoproj-labs/argocd-operator#1547, argoproj-labs/argocd-operator#1580.
Have you updated the necessary documentation?
Upstream documentation is added with argoproj-labs/argocd-operator#1579
Which issue(s) this PR fixes:
Fixes #629
GITOPS-5232
How to test changes / Special notes to the reviewer:
kubectl kuttl test ./test/openshift/e2e/parallel --config ./test/openshift/e2e/parallel/kuttl-tests.yaml --test 1-005_validate_route_tls