Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest commit of argo-rollouts-manager '85db81b64541a2e0f10616acca8b24ac63f46b42' #799

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Update to latest commit of argo-rollouts-manager '85db81b64541a2e0f10616acca8b24ac63f46b42' #799

merged 1 commit into from
Oct 23, 2024

Conversation

jgwest
Copy link
Collaborator

@jgwest jgwest commented Oct 23, 2024

Update to most recent 'argo-rollouts-manager' commit: argoproj-labs/argo-rollouts-manager@85db81b

@jgwest
Update to latest commit of argo-rollouts-manager '85db81b64541a2e0f10…
67256d3 
…616acca8b24ac63f46b42'

Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest
Copy link
Collaborator Author

jgwest commented Oct 23, 2024

/retest

        --- FAIL: kuttl/harness/1-052_validate_rolebinding_number (6.32s)
        --- FAIL: kuttl/harness/1-057_validate_notifications (107.67s) 
        --- FAIL: kuttl/harness/1-040_validate_quoted_RBAC_group_names (10.02s)

chetan-rns
chetan-rns approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 02be501 into redhat-developer:master Oct 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chetan-rns chetan-rns chetan-rns approved these changes

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@svghadi svghadi Awaiting requested review from svghadi

Assignees

@chetan-rns chetan-rns

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgwest @chetan-rns