Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition in e2e test 1-057_validate_notifications #817

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jparsai
Copy link
Collaborator

@jparsai jparsai commented Dec 2, 2024

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:
Fixes race condition in e2e test 1-057_validate_notifications.

Fixes
RH issue tracker :- https://issues.redhat.com/browse/GITOPS-5968

Signed-off-by: Jayendra Parsai <jparsai@jparsai-thinkpadp1gen4i.remote.csb>
Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jparsai
Copy link
Collaborator Author

jparsai commented Dec 2, 2024

/test v4.12-kuttl-parallel

@jparsai jparsai changed the title fix: fix race condition in e2e test 1-057_validate_notifications fix: race condition in e2e test 1-057_validate_notifications Dec 3, 2024
Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jparsai!

@jgwest jgwest merged commit 0a7bdac into redhat-developer:master Dec 5, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants