Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added IC-2023.2 to verified platforms (#193) #194

Merged
merged 5 commits into from
Sep 22, 2023
Merged

chore: added IC-2023.2 to verified platforms (#193) #194

merged 5 commits into from
Sep 22, 2023

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Jul 31, 2023 •
edited
Loading

fixes #193

@adietish adietish self-assigned this Jul 31, 2023
@adietish adietish requested a review from JessicaJHee July 31, 2023 10:17
@adietish adietish changed the title added IC-2023.2 to verified platforms (#193) chore: added IC-2023.2 to verified platforms (#193) Jul 31, 2023
@adietish adietish requested review from sbouchet and removed request for JessicaJHee July 31, 2023 22:10
sbouchet
sbouchet reviewed Aug 14, 2023
View reviewed changes
.github/workflows/IJ.yml Outdated Show resolved Hide resolved
@adietish
chore: added IC-2023.2 to verified platforms (redhat-developer#193)
ecd4f2a 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish requested a review from sbouchet September 7, 2023 12:27
@adietish adietish marked this pull request as draft September 7, 2023 12:51
@sbouchet
Copy link
Contributor

sbouchet commented Sep 8, 2023

seems like some work needs to be done for next release of IJ...

@adietish
Copy link
Contributor Author

seems like some work needs to be done for next release of IJ...

yes, there's stuff to fix before this is ready. I noticed this end of last week before devtools week and thus set it to draft.

@adietish
fix: build with jdk17/jdk11 depending on IC version (#552)
fea96aa 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
fix: replaced deprecated fixture factory method (redhat-developer#193)
abf8955 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
fix: bumped mockito to 5.2.0 (redhat-developer#193)
fc8cf79 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish marked this pull request as ready for review September 21, 2023 12:42
@adietish
Copy link
Contributor Author

@sbouchet please review. Quite some changes. Many caused by the need to compile using jdk17 when using IC-2023.2.

@adietish
added snakeyaml in tests to override incompat version in IC-2023.2
c779e35 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sbouchet
sbouchet approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
however but seems not causing any troubles yet, there is a warning in all versions on :
/home/runner/work/intellij-common/intellij-common/src/test/java/com/redhat/devtools/intellij/common/actions/editor/RemoveYAMLClutterActionHandlerTest.java uses or overrides a deprecated API.

@adietish adietish merged commit e644da6 into redhat-developer:main Sep 22, 2023
@adietish adietish deleted the issue-193 branch September 22, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
IDE Cloudaptors
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add IC-2023-2 to verification
2 participants
@adietish @sbouchet