Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: allow multiple configs listed in KUBECONFIG (#779)" #806

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Oct 25, 2024

reverts #779, commit d5972d2.

We merged #779 because things compiled and ran nicely. But then, when implementing the means to compile against IC-2024.2 plugin verifier started to complain (see #801) because it didnt see the modified kubernetes-client classes that existed in the plugin, that were shadowing the ones in the client-jar.

I tried the following without success:

  • moved the classes src/main/java -> src/main/kotlin (verifier still complained)
  • renamed the package with the shadowing classes (invovles copying even more classes, changing classes in the plugin)
  • masked the calls to new method that dont exist in the client-jar using reflection (requires changing classes in the plugin)

When trying reflection we decided to abandon the stop gap solution and wait for the release of the kubernetes-client 7.0.0 which should include the required changes.

@adietish adietish requested a review from sbouchet October 25, 2024 14:18
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, let's hope this will un-block #801 and let's also wait for kubeclient 7.0.0 to be out

@sbouchet sbouchet changed the title Revert "fix: allow multiple configs listed in KUBECONFIG (#779)" revert: Revert "fix: allow multiple configs listed in KUBECONFIG (#779)" Oct 25, 2024
…eloper#779)"

This reverts commit d5972d2.

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish changed the title revert: Revert "fix: allow multiple configs listed in KUBECONFIG (#779)" revert: "fix: allow multiple configs listed in KUBECONFIG (#779)" Oct 25, 2024
Copy link

@adietish adietish merged commit c9af008 into redhat-developer:main Oct 25, 2024
14 checks passed
@adietish adietish deleted the revert_779 branch October 25, 2024 15:06
@adietish adietish self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants