Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should send country abbreviation, not country display name #30

Closed
adietish opened this issue Aug 25, 2021 · 1 comment · Fixed by #31
Closed

Should send country abbreviation, not country display name #30

adietish opened this issue Aug 25, 2021 · 1 comment · Fixed by #31
Assignees
Labels
bug Something isn't working priority/high
Milestone

Comments

@adietish
Copy link
Contributor

adietish commented Aug 25, 2021

Our library sends the display name of the country in actions:

"location": {
      "country": "Switzerland"
},

the telemetry for vscode sends the country abbreviation:

"location": {
      "country": "CN"
},

We have to correct this in order to be consistent.
This results in an empty "most recent country" coulum in Woopra activities. This is also causing problems when sending segment data to http://pendo.io/ (instead of woopra)

@adietish adietish self-assigned this Aug 25, 2021
@adietish adietish added this to the 0.0.2 milestone Aug 25, 2021
@adietish adietish added bug Something isn't working priority/high labels Aug 25, 2021
@adietish
Copy link
Contributor Author

This could be caused by the following code in our library:
https://github.com/redhat-developer/intellij-redhat-telemetry/blob/main/src/main/java/com/redhat/devtools/intellij/telemetry/core/service/Country.java#L64-L71

        if (abbreviation == null) {
            String alternative = timezone.get(KEY_ALTERNATIVE);
            if (alternative == null) {
                return timezoneId;
            }
            return get(alternative);
        }
        return getDisplayName(abbreviation);

adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 2, 2021
…r#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 2, 2021
…eloper#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 2, 2021
…eloper#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 2, 2021
…eloper#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 2, 2021
…eloper#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 2, 2021
…eloper#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 2, 2021
…eloper#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit that referenced this issue Sep 3, 2021
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish added a commit to adietish/intellij-redhat-telemetry that referenced this issue Sep 3, 2021
…r#30)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant