fix: removed unnecessary StartupMessage#time, no NPE when exc in error() is null

[adietish]

Different cleanups, the initial idea in this PR was refuted (See comment #15 (comment)).

Keeping the initial idea for documentational/informational purposes:

In tekton ShowLogsAction and FollowLogsAction extend LogBaseAction. When invoked (ex. via context menu) LogBaseAction#actionPerfomed is called.
it would be handy to be able to have telemetry in a instance variable: declare and set the instance variable in ShowLogsAction and FollowLogsAction, use it there. and in the super class LogBaseAction. More handy than to pass telemetry along in a method parameters.
Actions are instantiated once per IDEA session and are reused on each invocation. The telemetry message builder is stateful: you set the parameters and finish by building & sending the message. So there are 2 alternatives:

• create a new instance in LogBaseAction#actionPerformed
• clear the builder once the message is sent (so that it can be reused)

[adietish]

to rely on the message builder to mangle it's internal state is a bad idea: clearing the properties is not enough, the "started" timestamp also has to be cleared:
We report a "duration" property to segment. To determine this we need a start/end timestamp. Both can be set explicitly but I try to track it automatically. The message sets the started timestamp when the message is instantiated (TelemetryService.instance().action("follow logs")). "Stopped" is set when the message is sent.
If the message is stored in a instance variable in an IJ Action, the message will have the "started" timestamp of when the IJ Action was instantiated. When the message builder is re-used the "started" timestamp needs to be set explicitly. I could alternatively set it whenever any other property is set. This feels too much error-prone though. Too much magic creates messy, unreliable code.
I thus think that it's far better to require the user programmer to create a new message builder on each Action#actionPerformed.

[adietish]

@jeffmaury, @lstocchi rebased, please review

[adietish]

closed by mistake. Reopening.

[lstocchi]

LGTM

[jeffmaury]

I don't like the renaming because you endup with builder.send() where it should be logically builder.build().send().
So it's ok for me to have non builder beans that returns this in setter methods and that would be easier to understand for novice users.
Unless I missed something

[adietish]

I don't like the renaming because you endup with builder.send() where it should be logically builder.build().send().

+1, I became doubtful of the renaming in the meantime but still kept it. Reverting it.